Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min 30gwei polygon main and mumbai fees #1671

Merged
merged 4 commits into from Dec 22, 2022
Merged

Min 30gwei polygon main and mumbai fees #1671

merged 4 commits into from Dec 22, 2022

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Dec 20, 2022 •
edited

Fixes #1670 .

Changes proposed in this PR:

  • sets 30 gwei threshold for maxFeePerGas & maxPriorityFeePerGas on Polygon main and mumbai networks

@codeclimate
Copy link

codeclimate bot commented Dec 21, 2022

Code Climate has analyzed commit 50c6eec and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.0% (0.0% change).

View more on Code Climate.

@bogdanfazakas bogdanfazakas marked this pull request as ready for review December 21, 2022 09:40
jamiehewitt15
jamiehewitt15 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It would be good to have this released and the tested on the release-candidate-09-01-2023 branch in the market

@bogdanfazakas bogdanfazakas merged commit 8de514f into main Dec 22, 2022
@bogdanfazakas bogdanfazakas deleted the fix/polygon-min-txfee branch December 22, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@kremalicious kremalicious Awaiting requested review from kremalicious

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transactions on Mumbai & Polygon should be min = 30gwei
2 participants
@bogdanfazakas @jamiehewitt15