Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating test command in readme #1663

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Updating test command in readme #1663

merged 4 commits into from
Dec 9, 2022

Conversation

jamiehewitt15
Copy link
Member

Changes proposed in this PR:

  • The readme currently has the wrong test command, this PR updates it

@kremalicious kremalicious self-requested a review December 7, 2022 23:38
Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text and code don’t match, as we have a total of 4 test commends and at least 2 should be mentioned here (test:unit & test:integration). Or create a npm script test which actually does what the text says, and then we don’t need to change the command here

@jamiehewitt15
Copy link
Member Author

Or create a npm script test which actually does what the text says, and then we don’t need to change the command here

Yeah, that's better. Presumably it was there before and got deleted by mistake.

@kremalicious
Copy link
Contributor

To quote:

Executing linting, type checking, unit, and integration tests

Last push does not make npm test run all those

@codeclimate
Copy link

codeclimate bot commented Dec 8, 2022

Code Climate has analyzed commit dacc6aa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 79.9% (0.0% change).

View more on Code Climate.

@kremalicious kremalicious merged commit bd395d0 into main Dec 9, 2022
@kremalicious kremalicious deleted the readme-fix branch December 9, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants