Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ipfs interface to getFileInfo #1640

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

EnzoVezzaro
Copy link
Contributor

Changes proposed in this PR:

  • added ipfs interface to getFileInfo

@mihaisc
Copy link
Contributor

mihaisc commented Oct 27, 2022

why no add all the types files: UrlFile[] | GraphqlQuery[] | Arweave[] | Smartcontract[] | Ipfs[] ?

@EnzoVezzaro
Copy link
Contributor Author

EnzoVezzaro commented Oct 27, 2022

why no add all the types files: UrlFile[] | GraphqlQuery[] | Arweave[] | Smartcontract[] | Ipfs[] ?

Sounds good to me 👍🏽 I'm working on the IPFS / Arweave intergration, that's why I didn't propose them all. But true, we can add all of them 👍🏽

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2022

Code Climate has analyzed commit c62550a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 79.9% (0.0% change).

View more on Code Climate.

@kremalicious kremalicious merged commit cdb9f8e into main Nov 1, 2022
@kremalicious kremalicious deleted the fix/issue-1639-added-ipfs-interface-getFileInfo branch November 1, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing IPFS interface in getFileInfo
4 participants