Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty commit to gain PR workflow approval #1629

Conversation

MantisClone
Copy link
Contributor

This is an empty PR that once merged, should allow me to run workflows in my other ocean.js PRs without requiring approval from an Ocean core team member every time.

image

@MantisClone
Copy link
Contributor Author

@alexcos20 @kremalicious @mihaisc @bogdanfazakas Would one of you be willing to merge this PR so that I don't need to request approval every time one of my other PRs wants to run CI checks? Or maybe you could mark me as an external contributor on this repo?

The coverage test is failing because PRs from external contributors do not have access to secrets like CC_REPORTER_ID

@LoznianuAnamaria
Copy link
Contributor

Hi @MantisClone ! I understand it is frustrating to ask for CI runs but let's stick to the process, please.
Once your PR is approved and merged, you will become a contributor, and you will be able to run CI on the repo. Until then, please feel free to run the CI locally using the instructions provided in the main ocean.js README: https://github.com/oceanprotocol/ocean.js.
Thanks for your understanding!

@MantisClone MantisClone deleted the dummy-commit-first-time-contributor branch October 6, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants