Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching prices from Aquarius in AssetList component #1774

Merged
merged 43 commits into from
Feb 9, 2023
Merged

Fetching prices from Aquarius in AssetList component #1774

merged 43 commits into from
Feb 9, 2023

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Nov 7, 2022 •
edited by kremalicious

Changes proposed in this PR:

  • Fetching prices from Aquarius in AssetList component

@vercel
Copy link

vercel bot commented Nov 7, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
market ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 9:08AM (UTC)

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review November 7, 2022 14:11
@jamiehewitt15 jamiehewitt15 marked this pull request as draft November 7, 2022 14:30
@jamiehewitt15 jamiehewitt15 self-assigned this Nov 8, 2022
@jamiehewitt15
Copy link
Member Author

Running into an issue with this where occasionally we don't receive the price from Aquarius oceanprotocol/aquarius#853 (comment)

@jamiehewitt15 jamiehewitt15 mentioned this pull request Nov 16, 2022
Closed
@kremalicious
Copy link
Contributor

Has this been abandoned?

@jamiehewitt15
Copy link
Member Author

Has this been abandoned?

Currently blocked by oceanprotocol/aquarius#928 as we're not receiving the prices from Aquarius every time. I'll pick it back up when the Aquarius refactor is deployed

@jamiehewitt15 jamiehewitt15 added the Status: Blocked Blocked by dependency, platform requirement, etc (add comment to detail the reason) label Nov 28, 2022
@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review January 26, 2023 11:25
bogdanfazakas
bogdanfazakas approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging this pls copy the package-lock.json file content from main branch since we should not touch that if we have not updated the dependency

kremalicious
kremalicious suggested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be all working as expected from functionality standpoint. Now please solve conflicts and address review comments

@jamiehewitt15
Copy link
Member Author

seems to be all working as expected from functionality standpoint. Now please solve conflicts and address review comments

Cool, thanks for the review. I'll address the comments

@codeclimate
Copy link

codeclimate bot commented Feb 8, 2023

Code Climate has analyzed commit 7a2c4ac and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 36.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 22.0% (-0.3% change).

View more on Code Climate.

@kremalicious kremalicious merged commit ed4645e into main Feb 9, 2023
@kremalicious kremalicious deleted the issue-1654-price-aquarius branch February 9, 2023 09:25
@LucaMilanese90 LucaMilanese90 mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kremalicious kremalicious kremalicious approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@EnzoVezzaro EnzoVezzaro Awaiting requested review from EnzoVezzaro

Assignees

@jamiehewitt15 jamiehewitt15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch price from aquarius
4 participants
@jamiehewitt15 @kremalicious @bogdanfazakas @mihaisc