Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use goblin as elf parser and only load segments on demand #315

Merged
merged 1 commit into from Feb 4, 2021

Conversation

jessehui
Copy link
Contributor

@jessehui jessehui commented Jan 15, 2021

Libos now Only read in headers and needed segments. Also reduce a memory
copy.

@guzongmin guzongmin added the SGX-hardware-test-required SGX-hardware-test-required label Jan 16, 2021
@jessehui jessehui force-pushed the dev_lazy_loading branch 4 times, most recently from c94f6b5 to 236a78a Compare January 19, 2021 10:55
@jessehui jessehui marked this pull request as draft January 26, 2021 11:05
@jessehui jessehui changed the title Use goblin as elf parser and change elf loading a bit lazy Use goblin as elf parser and only load segments on demand Jan 26, 2021
@jessehui jessehui marked this pull request as ready for review January 27, 2021 03:20
@jessehui jessehui force-pushed the dev_lazy_loading branch 2 times, most recently from 925669e to fc385fb Compare February 1, 2021 06:51
@jessehui
Copy link
Contributor Author

jessehui commented Feb 1, 2021

Changes for goblin have been merged (m4b/goblin#254) and changes for SEFS can be found here.

@guzongmin guzongmin added SGX-hardware-test-required SGX-hardware-test-required and removed SGX-hardware-test-required SGX-hardware-test-required labels Feb 1, 2021
Libos now Only read in headers and needed segments. Also reduce a memory
copy.
Copy link
Contributor

@guzongmin guzongmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guzongmin guzongmin merged commit 1fab796 into occlum:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SGX-hardware-test-required SGX-hardware-test-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants