Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the development workflow for node.js v17 #905

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

ocavue
Copy link
Owner

@ocavue ocavue commented Jan 7, 2022

Node.js v17 will resolve "localhost" as IPv6 address ::1 instead of 127.0.0.1. This causes some issues when using jest-playwright and wait-on. Fixed it by explicitly setting host to 127.0.0.1.

See also:

jeffbski/wait-on#109
nodejs/node#39987
nodejs/node#40537

@ocavue ocavue merged commit 642f8a5 into master Jan 7, 2022
@ocavue ocavue deleted the chore/node17 branch January 7, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant