Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Selenium #2183

Merged
merged 2 commits into from Oct 24, 2023
Merged

fix: Update Selenium #2183

merged 2 commits into from Oct 24, 2023

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Oct 13, 2023

This PR is needed because:


This change is Reviewable

@faucomte97 faucomte97 self-assigned this Oct 13, 2023
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 39 of 39 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2183 (28db12e) into master (9793686) will increase coverage by 0.04%.
Report is 9 commits behind head on master.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
+ Coverage   94.40%   94.44%   +0.04%     
==========================================
  Files         166      168       +2     
  Lines        4555     4590      +35     
==========================================
+ Hits         4300     4335      +35     
  Misses        255      255              
Files Coverage Δ
cfl_common/common/helpers/organisation.py 100.00% <ø> (ø)
...mon/common/migrations/0041_populate_gb_counties.py 88.23% <100.00%> (ø)
...n/common/migrations/0044_update_activity_models.py 100.00% <100.00%> (ø)
cfl_common/common/migrations/0045_otp.py 100.00% <100.00%> (ø)
cfl_common/common/models.py 89.91% <100.00%> (+0.24%) ⬆️
cfl_common/common/tests/test_models.py 100.00% <100.00%> (ø)
portal/__init__.py 100.00% <100.00%> (ø)
portal/urls.py 100.00% <ø> (ø)
portal/views/cron/user.py 92.22% <96.15%> (+1.31%) ⬆️

@faucomte97 faucomte97 merged commit 8f2b9a0 into master Oct 24, 2023
6 checks passed
@faucomte97 faucomte97 deleted the update_selenium branch October 24, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants