Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI broken #3198

Closed
1 task done
d-chambers opened this issue Nov 1, 2022 · 3 comments
Closed
1 task done

CI broken #3198

d-chambers opened this issue Nov 1, 2022 · 3 comments
Labels
bug confirmed bug CI issue generally related to continuous integration external It's not our fault! release blocker critical issues blocking the corresponding future release testing issues generally related to our testing setup / infrastructure

Comments

@d-chambers
Copy link
Member

d-chambers commented Nov 1, 2022

Avoid duplicates

  • I searched existing issues

Bug Summary

It appears the current CI installation is not sufficient to resolve all of the deps for testing. See here.

I can reproduce this issue locally by using the appropriate env file in the .github folder and installing obspy with

pip install . --no-deps

However, if I replace the no deps with an editable installation everything works fine

pip install  -e .

I think this was mentioned in #3176 but I didn't follow that thread completely. Any ideas why this is setup this way @trichter or @megies ?

Installation Method?

developer installation / from source / git checkout

@d-chambers d-chambers added bug-unconfirmed reported bug that still needs to be confirmed release blocker critical issues blocking the corresponding future release testing issues generally related to our testing setup / infrastructure CI issue generally related to continuous integration labels Nov 1, 2022
@trichter
Copy link
Member

trichter commented Nov 1, 2022

I think this error is due to an issue in pytest-metadata, see pytest-dev/pytest-metadata#54. The new version of this package fixing the issue is available on pypi, but not yet in conda-forge. I expect the pip install without --no-deps downloads the latest version from pypi and overwrites the version installed by conda.

@d-chambers
Copy link
Member Author

Ah, great thanks @trichter you are on the ball.

I opened an issue with the conda-forge feedstock to see if the maintainers would be willing to push out a new version. Hopefully when that happens the issue will be resolved.

@d-chambers
Copy link
Member Author

The conda-forge maintainers of pytest-metadata released a new version and CI appears to work again. For reference, here is the relevant pytest PR which explains that parts of the py library are now vendor-ed and other parts not, hence why an attribute error is raised rather than an import error in older versions of pytest-metadata.

@trichter trichter added bug confirmed bug external It's not our fault! and removed bug-unconfirmed reported bug that still needs to be confirmed labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug CI issue generally related to continuous integration external It's not our fault! release blocker critical issues blocking the corresponding future release testing issues generally related to our testing setup / infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants