New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type=module; update dependencies #342
Conversation
1612b68
to
afc1c2b
Compare
I had the same remark for caltrain, which I had changed differently. I prefer your version (change the data rather than the accessors). |
I can't build the bundle:
The error message seems to imply that we have to add "./package.json": "./package.json" in d3's exports, but that in turns creates more issues. I'm not sure what's happening. |
Strange. You might need Node 14? Actually maybe I didn’t test that step and only ran the tests. I’ll check. |
❯ node -v |
Yea, I hadn’t run prepublishOnly. I can reproduce and will work on a fix. |
Okay, fixed by using the relative path |
Supersedes part of #436; let’s change that PR into just the mode reducer.
One interesting review note: the caltrain.js test had to be tweaked because it was mixing strings and numbers in the y-scale. In D3 6, the numbers were coerced to strings and considered equivalent; in D3 7, ordinal scales now use InternMap which considers these values to be distinct. I like that the code is more explicit now.