Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The geometry channels accepts a channelSpec #1831

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 24, 2023

The geometry channels accepts a specialized channelSpec {value: …, scale: null} that allows a geo mark to opt out of the projection.

TODO:

  • we need to do the same for the centroid transform.

closes #1673

that allows a geo mark to opt out of the projection.
@Fil Fil requested a review from mbostock August 24, 2023 11:20
src/marks/geo.d.ts Outdated Show resolved Hide resolved
@Fil Fil marked this pull request as ready for review August 25, 2023 20:28
src/marks/geo.d.ts Outdated Show resolved Hide resolved
src/marks/geo.js Outdated Show resolved Hide resolved
src/marks/geo.js Outdated Show resolved Hide resolved
src/marks/geo.js Outdated Show resolved Hide resolved
@mbostock mbostock mentioned this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The geo mark ignores scale overrides for the geometry channel
2 participants