ensure thresholds consistency across facets #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
requested changes
Jan 16, 2023
src/marks/contour.js
Outdated
| @@ -158,7 +158,12 @@ function contourGeometry({thresholds, interval, ...options}) { | |||
| ? thresholds.range(...(([min, max]) => [thresholds.floor(min), max])(finiteExtent(VV))) | |||
| : typeof thresholds === "function" | |||
| ? thresholds(V, ...finiteExtent(VV)) | |||
| : thresholds; | |||
| : typeof thresholds === "number" | |||
| ? ticks(...nice(...finiteExtent(VV), thresholds), thresholds) | |||
There was a problem hiding this comment.
This isn’t sufficient. We’ll need these lines too (d3/d3-contour#68):
mbostock
force-pushed
the
fil/contour-facet-thresholds
branch
from
b76ee01
to
67b6e4f
Compare
mbostock
approved these changes
Jan 17, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* ensure thresholds consistency across facets * arrayify Co-authored-by: Mike Bostock <mbostock@gmail.com> * nice ticks; use contour * polish Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using thresholds: 10 would create 10 different levels on each facet; this ensures they are consistent, like we do with the bin transform.