Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs pages #540

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Inputs pages #540

merged 2 commits into from
Jan 13, 2024

Conversation

allisonhorst
Copy link
Contributor

Updates all individual inputs pages.

  • Adds API reference link atop each page
  • Adds options at end of each page
  • Updates inputs to lowercase throughout
  • Removes "components" - refers to "inputs" (e.g. "text input") throughout
  • Updates link to d3.group page (per Fil's feedback)
  • Removes athletes.csv and penguins.csv (uses olympians and penguins sample datasets)
  • Updates Inputs.file()

Several remaining TODOs as comments.

@allisonhorst allisonhorst mentioned this pull request Jan 13, 2024
Merged
9 tasks
Fil
Fil reviewed Jan 13, 2024
View reviewed changes
docs/inputs/color.md
@@ -18,7 +20,7 @@ const fill = view(Inputs.color({label: "Fill", value: d3.color("steelblue").form

If you specify the *datalist* option as an array of hexadecimal color strings, the color picker will show this set of colors for convenient picking. (The user will still be allowed to pick another color, however; if you want to limit the choice to a specific set, then a radio or select input may be more appropriate.)

<!-- [TODO] update to the new Observable color palette? -->
<!-- [TODO] update to the new Observable10 color palette? -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be lovely, but depends on d3/d3-scale-chromatic#51

@allisonhorst allisonhorst merged commit 2fe2fbc into components Jan 13, 2024
@allisonhorst allisonhorst deleted the allison/inputs-pages branch January 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

@mbostock mbostock Awaiting requested review from mbostock

@cinxmo cinxmo Awaiting requested review from cinxmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allisonhorst @Fil