Add semver check for unit structs becoming plain structs. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonowak
added a commit
to staniewzki/cargo-semver-check
that referenced
this pull request
Jan 22, 2023
obi1kenobi
added a commit
that referenced
this pull request
Jan 23, 2023
* Load rustdoc immediately into memory Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Running the lints immediately after creating the rustdocs * fmt * Update src/main.rs Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Review adjustments * Extract rustdoc generation Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Minor adjustments Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Add clap run to CI Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Edit CI Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Undo typo Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * replace ! with not Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Try another way to negate Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * CI fix attempt #3 * Adjust comments Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Remove redundant check Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> * Require the new job to succeed before CI passes * Quote shell expansions in GitHub Action Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com> Co-authored-by: Tomasz Nowak <tomek.nowak.gm.16@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
obi1kenobi
pushed a commit
that referenced
this pull request
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References a link added in rust-lang/cargo#10871 which would ideally merge first.