Make UtilsTests.test_filter_params Python 3.13+ compatible #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.13.0a1, docstrings are automatically dedented. See python/cpython#81283 and https://docs.python.org/3.13/whatsnew/3.13.html#other-language-changes As a result, using a docstring with leading space as a test case breaks the test assumption. The initial commit which introduced this test a decade ago (6c0c791) does not specify why testing the spaces is important.
auvipy
requested changes
Oct 24, 2023
|
auvipy
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.13.0a1, docstrings are automatically dedented. See python/cpython#81283 and https://docs.python.org/3.13/whatsnew/3.13.html#other-language-changes
As a result, using a docstring with leading space as a test case breaks the test assumption.
The initial commit which introduced this test a decade ago (6c0c791)
does not specify why testing the spaces is important.