Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint with ruff to replace bandit, flake8, isort, pyupgrade #855

Merged
merged 2 commits into from Aug 24, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 24, 2023

Ruff supports over 600 lint rules and can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing (in Rust) tens or hundreds of times faster than any individual tool.

ruff --format=github rapidly provides intuitive GitHub Annotations to contributors.

image

Copy link
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auvipy auvipy merged commit 8b33f83 into oauthlib:master Aug 24, 2023
1 check passed
@cclauss cclauss deleted the ruff branch August 24, 2023 16:39
@cclauss
Copy link
Contributor Author

cclauss commented Aug 28, 2023

@JonathanHuot @auvipy These changes to .github/workflows/lint_python.yml all seem to be reverted.
Was this intentional or just a result of merging out-of-sync code? If the latter, should I recreate these changes?

@JonathanHuot
Copy link
Member

Hi @cclauss, it seems you're right! lasts merge has been overriding changes.. what a mess .. even reading history is now broken somehow. Happy if you recreate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants