Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the device authorization endpoint #844

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

oliamb
Copy link

@oliamb oliamb commented Mar 24, 2023

This is a follow-up PR proposal for issue #626. It implements Section 3.1 and Section 3.2 of RFC8628. PR #640 is related and arguably more advanced. But it is a bit old now and relates to the draft specification.

This is my first submission here. I think I followed the Contributing Guidelines, but please let me know if I am doing it wrong.

@oliamb oliamb mentioned this pull request Mar 24, 2023
@auvipy auvipy self-requested a review March 24, 2023 16:04
@dopry
Copy link

dopry commented Oct 4, 2023

@oliamb do you have time to address the lint issues, that might help get this on a maintainers radar for review.

@oliamb oliamb force-pushed the device_authorization_endpoint branch from e7e02a2 to 2ab2822 Compare October 4, 2023 16:47
@oliamb
Copy link
Author

oliamb commented Oct 5, 2023

Thanks @dopry. I did not even see that there was a lint issue. This should be fixed now.

@auvipy
Copy link
Contributor

auvipy commented Oct 5, 2023

lets wait for the CI

@oliamb oliamb force-pushed the device_authorization_endpoint branch 2 times, most recently from 78cfc8d to f7c8369 Compare October 5, 2023 08:17
@oliamb
Copy link
Author

oliamb commented Oct 5, 2023

The linter fails at other points now, but I can see this is from code outside the original PR. I rebased my branch on top of the master yesterday. I don't think I should fix files outside the PR scope, WDYT? I don't manage to get consistent results on my local with the linter because I think the linter libraries' versions are not pinned (i.e. they are installed through the command pip install black codespell mypy pytest ruff safety).

@dopry
Copy link

dopry commented Oct 5, 2023

I would treat upstream lint issues as out of scope, if I did want to fix them I would submit it as a separate PR.

@ondrados
Copy link

Hello, what is the current status? Can this be merged?

@dopry
Copy link

dopry commented Apr 15, 2024

@auvipy do you have any thoughts on clearing the lint issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants