Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Travis to GitHub Actions CI #834

Merged
merged 16 commits into from Aug 26, 2023
Merged

Move from Travis to GitHub Actions CI #834

merged 16 commits into from Aug 26, 2023

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Sep 10, 2022

No description provided.

@auvipy
Copy link
Contributor Author

auvipy commented Sep 11, 2022

IMHO, link and test actions should be different

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss
Copy link
Contributor

cclauss commented Aug 23, 2023

Sorry. I proposed the setuptools upgrade in the wrong file...

@cclauss
Copy link
Contributor

cclauss commented Aug 24, 2023

Please rebase because lint_python should now pass.

Maximilian Wirtz and others added 10 commits August 24, 2023 14:23
…ry (#835)

* Upgrade GitHub Actions

* Fix typo discovered by codespell

* Update lint_python.yml
The idea is to allow values like `0` to be used a state.
The current implementation only checks for truthiness.
… grant type (#838)

* Modify pre-configured OIDC server to use OIDC Refresh Token grant type

* Add test coverage for OIDC refresh token grant type

* Use longer variable names
Fixes the following warning:

> The license_file parameter is deprecated, use license_files instead.
@JonathanHuot
Copy link
Member

Looks good to me, next step would be to validate tag/publish once the release is ready. In the meantime, once reviewed, I propose to merge the PR and integrate other pending PRs (rebase) for release preparation.

@JonathanHuot JonathanHuot changed the title draft CI Move from Travis to GitHub Actions CI Aug 24, 2023
@JonathanHuot JonathanHuot marked this pull request as ready for review August 24, 2023 14:54
Co-authored-by: Christian Clauss <cclauss@me.com>
Copy link
Contributor Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge it as the primary CI is working. in another take we could verify the publishing mechanism

@auvipy
Copy link
Contributor Author

auvipy commented Aug 24, 2023

Jonathon, this needs yours approval for merge

@cclauss
Copy link
Contributor

cclauss commented Aug 24, 2023

This branch has conflicts that must be resolved

Please rebase on the current master

@auvipy
Copy link
Contributor Author

auvipy commented Aug 25, 2023

I should not merge the ruff one first!

@cclauss
Copy link
Contributor

cclauss commented Aug 25, 2023

You might try manually undoing all changes to .github/workflows/lint_python.yml (replace all the green lines with the red lines) and that might cure the git conflict. Or update your master branch and then:

git checkout CI
git pull  # just to be sure
git checkout master -- .github/workflows/lint_python.yml  # the dash-dash are significant
git commit -am"Update .github/workflows/lint_python.yml"

Copy link
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CI passing with success

@JonathanHuot JonathanHuot merged commit 7fb099a into master Aug 26, 2023
11 checks passed
@auvipy auvipy deleted the CI branch August 27, 2023 06:36
@auvipy auvipy added this to the 3.3.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants