New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Travis to GitHub Actions CI #834
Conversation
IMHO, link and test actions should be different |
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sorry. I proposed the |
Please rebase because |
…ry (#835) * Upgrade GitHub Actions * Fix typo discovered by codespell * Update lint_python.yml
The idea is to allow values like `0` to be used a state. The current implementation only checks for truthiness.
… grant type (#838) * Modify pre-configured OIDC server to use OIDC Refresh Token grant type * Add test coverage for OIDC refresh token grant type * Use longer variable names
Fixes the following warning: > The license_file parameter is deprecated, use license_files instead.
As discussed in #745
Looks good to me, next step would be to validate tag/publish once the release is ready. In the meantime, once reviewed, I propose to merge the PR and integrate other pending PRs (rebase) for release preparation. |
Co-authored-by: Christian Clauss <cclauss@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge it as the primary CI is working. in another take we could verify the publishing mechanism
Jonathon, this needs yours approval for merge |
This branch has conflicts that must be resolved Please rebase on the current |
I should not merge the ruff one first! |
You might try manually undoing all changes to git checkout CI
git pull # just to be sure
git checkout master -- .github/workflows/lint_python.yml # the dash-dash are significant
git commit -am"Update .github/workflows/lint_python.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM CI passing with success
No description provided.