Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show diff for changed scope #811

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdevries3133
Copy link

This is a draft PR to show a clean diff instead of a "splat" of text when a scope
change occurs. According to (my understanding of) RFC 6749 Section A.4, the only
allowed delimiter for oauth scopes is a space character:

A.4.  "scope" Syntax

   The "scope" element is defined in Section 3.3:

     scope       = scope-token *( SP scope-token )
     scope-token = 1*NQCHAR

Therefore, this implementation should be good to go. I updated tests so that
they pass with the change. Looking forward to feedback.

Please note that there could be a possible merge conflict with pr#810, so please
review and merge that less-controversial PR first so that I can resolve those
changes into this draft.

Thanks!

@jdevries3133 jdevries3133 changed the title Show draft for changed scope Show diff for changed scope Apr 1, 2022
@jdevries3133 jdevries3133 marked this pull request as draft April 1, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant