Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require plaintext signature method #135

Merged
merged 3 commits into from Nov 1, 2021
Merged

Require plaintext signature method #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
656d761
Require plaintext signature method
confiks Aug 8, 2016
2a7c6c8
Remove plaintext signature class requires from tests.
confiks Aug 8, 2016
6aad073
Instruct Travis CI to use a specific Rubygems version. Master is brok…
confiks Aug 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ addons:

language: ruby

before_install: rvm rubygems master --force
before_install: rvm rubygems v2.6.6 --force
install: gem install --file
script: "RUBYGEMS_GEMDEPS=- rake test"

Expand Down
1 change: 1 addition & 0 deletions lib/oauth.rb
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@
require 'oauth/core_ext'

require 'oauth/client/helper'
require 'oauth/signature/plaintext'
require 'oauth/signature/hmac/sha1'
require 'oauth/signature/rsa/sha1'
require 'oauth/request_proxy/mock_request'
4 changes: 1 addition & 3 deletions test/integration/consumer_test.rb
View file
Open in desktop
Expand Up @@ -32,7 +32,6 @@ def test_that_signing_auth_headers_on_get_requests_works
end

def test_that_setting_signature_method_on_consumer_effects_signing
require 'oauth/signature/plaintext'
request = Net::HTTP::Get.new(@request_uri.path)
consumer = @consumer.dup
consumer.options[:signature_method] = 'PLAINTEXT'
Expand All @@ -44,7 +43,6 @@ def test_that_setting_signature_method_on_consumer_effects_signing
end

def test_that_setting_signature_method_on_consumer_effects_signature_base_string
require 'oauth/signature/plaintext'
request = Net::HTTP::Get.new(@request_uri.path)
consumer = @consumer.dup
consumer.options[:signature_method] = 'PLAINTEXT'
Expand All @@ -58,7 +56,7 @@ def test_that_setting_signature_method_on_consumer_effects_signature_base_string

def test_that_plaintext_signature_works
# Invalid test because server expects double-escaped signature
require 'oauth/signature/plaintext'

# consumer = OAuth::Consumer.new("key", "secret",
# :site => "http://term.ie", :signature_method => 'PLAINTEXT')
# access_token = OAuth::AccessToken.new(consumer, 'accesskey', 'accesssecret')
Expand Down
1 change: 0 additions & 1 deletion test/units/test_em_http_client.rb
View file
Open in desktop
Expand Up @@ -27,7 +27,6 @@ def test_that_using_auth_headers_on_get_requests_works
end

def test_that_using_auth_headers_on_get_requests_works_with_plaintext
require 'oauth/signature/plaintext'
c = OAuth::Consumer.new('consumer_key_86cad9', '5888bf0345e5d237',{
:signature_method => 'PLAINTEXT'
})
Expand Down
1 change: 0 additions & 1 deletion test/units/test_net_http_client.rb
View file
Open in desktop
Expand Up @@ -25,7 +25,6 @@ def test_that_using_auth_headers_on_get_requests_works
end

def test_that_using_auth_headers_on_get_requests_works_with_plaintext
require 'oauth/signature/plaintext'
c = OAuth::Consumer.new('consumer_key_86cad9', '5888bf0345e5d237',{
:signature_method => 'PLAINTEXT'
})
Expand Down
1 change: 0 additions & 1 deletion test/units/test_signature_plain_text.rb
View file
Open in desktop
@@ -1,5 +1,4 @@
require File.expand_path('../../test_helper_units', __FILE__)
require 'oauth/signature/plaintext'

class TestSignaturePlaintext < Minitest::Test
def test_that_plaintext_implements_plaintext
Expand Down