Skip to content

Commit

Permalink
Remove plaintext signature class requires from tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
confiks committed Aug 8, 2016
1 parent 656d761 commit 2a7c6c8
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
4 changes: 1 addition & 3 deletions test/integration/consumer_test.rb
Expand Up @@ -32,7 +32,6 @@ def test_that_signing_auth_headers_on_get_requests_works
end

def test_that_setting_signature_method_on_consumer_effects_signing
require 'oauth/signature/plaintext'
request = Net::HTTP::Get.new(@request_uri.path)
consumer = @consumer.dup
consumer.options[:signature_method] = 'PLAINTEXT'
Expand All @@ -44,7 +43,6 @@ def test_that_setting_signature_method_on_consumer_effects_signing
end

def test_that_setting_signature_method_on_consumer_effects_signature_base_string
require 'oauth/signature/plaintext'
request = Net::HTTP::Get.new(@request_uri.path)
consumer = @consumer.dup
consumer.options[:signature_method] = 'PLAINTEXT'
Expand All @@ -58,7 +56,7 @@ def test_that_setting_signature_method_on_consumer_effects_signature_base_string

def test_that_plaintext_signature_works
# Invalid test because server expects double-escaped signature
require 'oauth/signature/plaintext'

# consumer = OAuth::Consumer.new("key", "secret",
# :site => "http://term.ie", :signature_method => 'PLAINTEXT')
# access_token = OAuth::AccessToken.new(consumer, 'accesskey', 'accesssecret')
Expand Down
1 change: 0 additions & 1 deletion test/units/test_em_http_client.rb
Expand Up @@ -27,7 +27,6 @@ def test_that_using_auth_headers_on_get_requests_works
end

def test_that_using_auth_headers_on_get_requests_works_with_plaintext
require 'oauth/signature/plaintext'
c = OAuth::Consumer.new('consumer_key_86cad9', '5888bf0345e5d237',{
:signature_method => 'PLAINTEXT'
})
Expand Down
1 change: 0 additions & 1 deletion test/units/test_net_http_client.rb
Expand Up @@ -25,7 +25,6 @@ def test_that_using_auth_headers_on_get_requests_works
end

def test_that_using_auth_headers_on_get_requests_works_with_plaintext
require 'oauth/signature/plaintext'
c = OAuth::Consumer.new('consumer_key_86cad9', '5888bf0345e5d237',{
:signature_method => 'PLAINTEXT'
})
Expand Down
1 change: 0 additions & 1 deletion test/units/test_signature_plain_text.rb
@@ -1,5 +1,4 @@
require File.expand_path('../../test_helper_units', __FILE__)
require 'oauth/signature/plaintext'

class TestSignaturePlaintext < Minitest::Test
def test_that_plaintext_implements_plaintext
Expand Down

0 comments on commit 2a7c6c8

Please sign in to comment.