Database loading statuses #5405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Oct 18, 2023
| localStorage, err := NewLocalBackend(commonNode.Runtime.DataDir(), id) | ||
| if err != nil { | ||
| return fmt.Errorf("can't create local storage backend: %w", err) | ||
| storageCtor := func(ctx context.Context) (storageApi.LocalBackend, error) { |
There was a problem hiding this comment.
Is there a reason why we don't create the local storage backend in committee/node? This would avoid passing in this factory function.
| @@ -200,6 +202,31 @@ func NewNode( | |||
|
|
|||
| n.ctx, n.ctxCancel = context.WithCancel(context.Background()) | |||
|
|
|||
| go func() { | |||
There was a problem hiding this comment.
Isn't doing this async dangerous? Where do we ensure that start is not called before this completes? Related goroutines should probably block on a channel that gets closed once this deferred init completes?
kostko
reviewed
Oct 18, 2023
go/worker/storage/worker.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("can't create local storage backend: %w", err) | ||
| } | ||
| commonNode.Runtime.RegisterStorage(localStorage) |
There was a problem hiding this comment.
Are there any issues if this happens async?
jberci
force-pushed
the
jberci/feature/dbstatus
branch
from
2fa23d8
to
1e986d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.