Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tokio to 1.20.x #4928

Merged
merged 1 commit into from Sep 12, 2022
Merged

Bump tokio to 1.20.x #4928

merged 1 commit into from Sep 12, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 12, 2022

No description provided.

@kostko kostko marked this pull request as ready for review September 12, 2022 10:26
@kostko kostko added the c:deps Category: external dependencies label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #4928 (91090a7) into master (10925b2) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 91090a7 differs from pull request most recent head c2c28b4. Consider uploading reports for the commit c2c28b4 to get more accurate results

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
- Coverage   66.71%   66.68%   -0.04%     
==========================================
  Files         464      464              
  Lines       51127    51127              
==========================================
- Hits        34110    34094      -16     
- Misses      12836    12848      +12     
- Partials     4181     4185       +4     
Impacted Files Coverage Δ
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/worker/keymanager/watcher.go 63.07% <0.00%> (-10.77%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.33% <0.00%> (-6.49%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/common/grpc/auth/auth.go 94.73% <0.00%> (-5.27%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/storage/mkvs/lookup.go 75.00% <0.00%> (-4.17%) ⬇️
go/consensus/tendermint/apps/registry/query.go 80.00% <0.00%> (-4.00%) ⬇️
go/common/sgx/common.go 66.01% <0.00%> (-3.89%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as described

@kostko
Copy link
Member Author

kostko commented Sep 12, 2022

The need to lock tokio to at most 1.20.x should be removed soon (tokio-rs/tokio#4999, tokio-rs/tokio#5000, tokio-rs/tokio#5001).

@kostko kostko merged commit 26aafd9 into master Sep 12, 2022
@kostko kostko deleted the kostko/feature/tokio-1.20.x branch September 12, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants