Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs reference to runtime version #4914

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update docs reference to runtime version #4914

wants to merge 2 commits into from

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Aug 29, 2022 •
edited

Why
deployments is a necessary field. Also, this updates the versioning on entity returned.

@aefhm aefhm self-assigned this Aug 29, 2022
@aefhm aefhm added p:3 Priority: nice to have c:docs Category: documentation labels Aug 30, 2022
kostko
kostko reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually needs many more changes, e.g. there is no more storage_receipts field, the versions field has been changed to deployments, various committee options have changed etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko left review comments

@Yawning Yawning Awaiting requested review from Yawning

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@aefhm aefhm

Labels
c:docs Category: documentation p:3 Priority: nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aefhm @kostko