common/flags: Fix parsing of metrics.labels, if provided in config .yml

[matevz]

Fixes #2905

[codecov]

Codecov Report

Merging #2906 into master will decrease coverage by 0.30%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
- Coverage   68.11%   67.80%   -0.31%     
==========================================
  Files         352      352              
  Lines       34235    34223      -12     
==========================================
- Hits        23318    23206     -112     
- Misses       7943     8017      +74     
- Partials     2974     3000      +26     

Impacted Files	Coverage Δ
go/oasis-node/cmd/common/flags/flags.go	94.73% <ø> (+12.73%)	⬆️
go/oasis-node/cmd/common/metrics/metrics.go	15.94% <0.00%> (ø)
go/oasis-node/cmd/common/logging.go	67.74% <100.00%> (+9.67%)	⬆️
go/consensus/tendermint/api/errors.go	86.66% <0.00%> (-13.34%)	⬇️
go/consensus/tendermint/apps/roothash/query.go	64.70% <0.00%> (-11.77%)	⬇️
go/worker/compute/executor/committee/state.go	74.07% <0.00%> (-11.12%)	⬇️
go/consensus/tendermint/abci/state/state.go	50.00% <0.00%> (-7.70%)	⬇️
go/storage/api/root_cache.go	72.41% <0.00%> (-6.90%)	⬇️
go/storage/metrics.go	81.52% <0.00%> (-6.53%)	⬇️
go/consensus/tendermint/apps/staking/state/gas.go	77.08% <0.00%> (-4.17%)	⬇️
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdcc044...e590637. Read the comment docs.

[kostko]

Thanks for the quick fix, would it be possible to add a small unit test?

[kostko]

Actually, looks like this was supposed to be fixed in viper 1.7.0 (see spf13/viper#874), can you test?

May be fixed upstream.

[matevz]

Fixed upstream, removed drop-in.