Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTyest, custom plugin, and remove unused dependency #13707

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

Kadino
Copy link
Contributor

@Kadino Kadino commented Dec 14, 2022

Signed-off-by: sweeneys sweeneys@amazon.com

What does this PR do?

Resolves #10588 and #12685 by updating to the latest version of PyTest. Also includes minor updates to make it easier to run tests locally.

How was this PR tested?

Tests pass when running the following command with CWD in o3de/build:
ctest -C profile -L "(SUITE_smoke|SUITE_main)" --no-tests=error --parallel 12 --output-on-failure

Signed-off-by: sweeneys <sweeneys@amazon.com>
@Kadino Kadino requested review from a team as code owners December 14, 2022 21:01
@Kadino Kadino marked this pull request as draft December 14, 2022 22:57
@Kadino
Copy link
Contributor Author

Kadino commented Dec 14, 2022

Marking PR as draft as it appears that it requires a Jenkins clean-build (and possibly additional steps) to prove functionality.

@@ -1,6 +1,10 @@
"""
r"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you prepending an r to this docstring block? I'm guessing this is something I don't know.

Copy link
Contributor Author

@Kadino Kadino Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes it a raw string. In this case to make sure it contains literal backslashes instead of using backslash as an escape character. I wanted the string below to be copyable from the file into a Windows CLI, while also not making garbled text in the docstring.

Signed-off-by: sweeneys <sweeneys@amazon.com>
Signed-off-by: sweeneys <sweeneys@amazon.com>
@Kadino Kadino marked this pull request as ready for review December 15, 2022 09:50
@Kadino Kadino requested review from a team December 15, 2022 09:51
@Kadino Kadino linked an issue Dec 15, 2022 that may be closed by this pull request
@Kadino Kadino merged commit 02f0438 into o3de:development Dec 16, 2022
@Kadino Kadino deleted the pytest_deps_and_plugin branch December 16, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Py library is insecure and needs patching Update PyTest and custom plugins
3 participants