Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scavenge some previous updates to be Rails 7 friendly #990

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

epugh
Copy link
Member

@epugh epugh commented Mar 28, 2024

Description

Made changes in #861 but put too many things into one PR. Now pick the best.

Motivation and Context

Rails 7.1 cause soon we want to be on 7.2!

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh mentioned this pull request Mar 28, 2024
@epugh
Copy link
Member Author

epugh commented Apr 11, 2024

need to figure out why our custom list and item support failed on this upgrade ;-(. Maybe look at "positioning" gem..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant