Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer display of scorers #556

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Richer display of scorers #556

wants to merge 6 commits into from

Conversation

epugh
Copy link
Member

@epugh epugh commented Aug 27, 2022

Description

adding in tool tip and description, and more critically, splitting how we calculate the score for "per query" and "per case". I.e, a score for query, and then your CaseScore is overall.... @david-fisher says we shouldn't just Average with every scorer, that some should be a Sum instead.

Motivation and Context

Make CaseScore, which I have in the past called your QScore... your QuepidScore... More meaningful...

Give newbie users a better sense of which scorer they should reach for!

How Has This Been Tested?

Still need to work on this.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [X ] Breaking change (fix or feature that would cause existing functionality to change)

@epugh epugh temporarily deployed to quepid-pr-556 August 27, 2022 14:08 Inactive
@epugh
Copy link
Member Author

epugh commented Aug 27, 2022

I've added a sumQueries method to join the existing avgQueries method on the https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L211 class... It's a placeholder and still does averaging! However, I don't quite understand how that all intersects with the runScores method, where the actual logic maybe occurs? https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L134

I'd love some ideas or fixes @david-fisher @worleydl !

@epugh epugh linked an issue Aug 29, 2022 that may be closed by this pull request
@david-fisher
Copy link
Contributor

I've added a sumQueries method to join the existing avgQueries method on the https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L211 class... It's a placeholder and still does averaging! However, I don't quite understand how that all intersects with the runScores method, where the actual logic maybe occurs? https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L134

I'd love some ideas or fixes @david-fisher @worleydl !

I believe the averaging happens in https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/services/queriesSvc.js line 1033 when setting the svc.latestScoreInfo inside the scoreAll function (line 991). Angular is not my thing, but that does seem to be the culprit.

@epugh epugh temporarily deployed to quepid-pr-556 October 5, 2022 16:45 Inactive
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers!

@stale stale bot added the wontfix This will not be worked on label Jan 7, 2023
@stale stale bot closed this Mar 25, 2023
@epugh
Copy link
Member Author

epugh commented Apr 19, 2023

Bump

@epugh epugh reopened this Apr 19, 2023
@stale stale bot removed wontfix This will not be worked on labels Apr 19, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers!

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
2 participants