Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to move from mb3 to mb4... #1016

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

epugh
Copy link
Member

@epugh epugh commented May 12, 2024

Description

This attempts to get us to mb4 everywhere...

However, one test on user names fails since we move from case insensitive LIKE query to a case sensitive due to the collation.

Motivation and Context

This is an attempt to fix #1013 but I am nervous about the ramifications.

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@wrigleyDan wrigleyDan reopened this May 17, 2024
@wrigleyDan
Copy link
Contributor

@epugh It looks like changing the collation from utf8_bin to utf8mb4_unicode_cisolved the failing test from before.

Now a DB migration test fails caused by this test: db/migrate/20240512144038_fix_query_doc_pairs_document_fields_type.rb

One step in the right direction, and one step back...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change charset in database schema to utf8mb4
2 participants