Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.60.2 → 1.63.5 (minor) #145

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 10, 2024

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.60.2 → 1.63.5) · Repo · Changelog

Release Notes

1.63.5

Bug fixes

  • #12877: Fix an infinite loop error for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArrayAlignment. (@koic)
  • #12873: Fix an error for Metrics/BlockLength when the CountAsOne config is invalid. (@koic)
  • #12881: Fix incorrect autocorrect when Style/NumericPredicate is used with negations. (@fatkodima)
  • #12882: Fix Layout/CommentIndentation for comment-only pattern matching. (@nekketsuuu)

1.63.4

Bug fixes

  • #12871: Fix an error for rubocop -V when .rubocop.yml contains ERB. (@earlopain)
  • #12862: Fix a false positive for Style/RedundantLineContinuation when line continuations involve return with a return value. (@koic)
  • #12664: Fix handling of textDocument/diagnostic. (@muxcmux)
  • #12865: Fix Rails Cops, which weren't reporting any violations unless running with bundle exec. (@amomchilov)

1.63.3

Bug fixes

  • #12857: Fix false negatives for Lint/UnreachableCode when using pattern matching. (@koic)
  • #12852: Fix an error for Lint/EmptyFile in formatters when using cache. (@earlopain)
  • #12848: Fix an error that occurs in RuboCop::Lockfile when the constant Bundler is uninitialized. (@koic)

Changes

  • #12855: Set custom program name for the built-in LSP server. (@koic)

1.63.2

Bug fixes

  • #12843: Fix an error for Lint/MixedCaseRange when a character between Z and a is used in the regexp range. (@koic)
  • #12846: Fix an error for RuboCop::Lockfile when there is no Bundler environment. (@koic)
  • #12832: Fix an error for Style/ArgumentsForwarding when using block arg in nested method definitions. (@koic)
  • #12841: Fix false negatives for Lint/UnreachableLoop when using pattern matching. (@koic)
  • #12835: Allow global offenses to be disabled by directive comments. (@earlopain)

Changes

  • #12845: Exclude debug/open_nonstop from Lint/Debugger by default. (@koic)

1.63.1

Bug fixes

  • #12828: Fix a false positive for Lint/AssignmentInCondition if assigning inside a method call. (@earlopain)
  • #12823: Fixed "uninitialized constant RuboCop::Lockfile::Bundler", caused when running RuboCop without bundler exec on codebases that use rubocop-rails. (@amomchilov)

1.63.0

New features

Bug fixes

  • #12769: Fix a false positive for Lint/RedundantWithIndex when calling with_index with receiver and a block. (@koic)
  • #12547: Added a comment recommending upgrading to the latest version of Rubocop in the error text when an Infinite loop detected error occurs. (@Hiroto-Iizuka)
  • #12782: Fix an error for Style/Alias with EnforcedStyle: prefer_alias when calling alias_method with fewer than 2 arguments. (@earlopain)
  • #12781: Fix an error for Style/ExactRegexpMatch when calling match without a receiver. (@earlopain)
  • #12780: Fix an error for Style/RedundantEach when using reverse_each.each without a block. (@earlopain)
  • #12731: Treat &. the same way as . for setter methods in Lint/AssignmentInCondition. (@jonas054)
  • #12793: Fix false positives for Style/RedundantLineContinuation when using line continuation with modifier. (@koic)
  • #12807: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others. (@koic)
  • #12796: Fix false positives for Style/EvalWithLocation when using eval with a line number from a method call or a variable. (@koic)
  • #12794: Fix false positives for Style/RedundantArgument when when single-quoted strings for cntrl character. (@koic)
  • #12797: Fix false positives for Style/RedundantLineContinuation when using line continuations with && or || operator in assignment. (@koic)
  • #12793: Fix false positives for Style/RedundantLineContinuation when multi-line continuations with operators. (@koic)
  • #12801: Fix incorrect autocorrect for Style/CollectionCompact when using delete_if. (@koic)
  • #12789: Make Style/RedundantPercentQ safe on multiline strings. (@boardfish)
  • #12802: Return global offenses for Naming/FileName and Naming/InclusiveLanguage for empty files. (@earlopain)
  • #12804: Return global offenses for Style/Copyright when the file is empty. (@earlopain)

Changes

  • #12813: Add rubocop-rspec_rails to suggested extensions and extension doc. (@ydah)
  • #12820: Add support more Capybara debugger entry points for Lint/Debugger. (@ydah)
  • #12676: Adjust offending range in LSP. (@koic)
  • #12815: Ignore Rakefile.rb in Naming/FileName in the default config. (@artur-intech)
  • #12800: Handle empty obsoletion config. (@sambostock)
  • #12721: Make Lint/Debugger aware of ruby/debug requires. (@earlopain)
  • #12817: Make rubocop -V display rubocop-rspec_rails version when using it. (@ydah)
  • #12180: Replace regex with Bundler::LockfileParser. (@amomchilov)

1.62.1

Bug fixes

  • #12761: Fix a false positive for Style/HashEachMethods when the key block argument of Enumerable#each method is unused after chunk. (@koic)
  • #12768: Fix a false positive for Style/NilComparison without receiver and EnforcedStyle: comparison. (@earlopain)
  • #12752: Fix an error for Gemspec/RequiredRubyVersion when the file is empty. (@earlopain)
  • #12770: Fix an error for Lint/RedundantWithIndex when the method has no receiver. (@earlopain)
  • #12775: Fix an error for Lint/UselessTimes when no block is present. (@earlopain)
  • #12772: Fix an error for Style/ClassVars when calling class_variable_set without arguments. (@earlopain)
  • #12773: Fix an error for Style/For with EnforcedStyle: for when no receiver. (@earlopain)
  • #12765: Fix an error for Layout/MultilineMethodCallIndentation with safe navigation and assignment method. (@earlopain)
  • #12703: Fix an error for Lint/MixedCaseRange with invalid byte sequence in UTF-8. (@earlopain)
  • #12755: Fix an exception for RedundantCurrentDirectoryInPath in case of require_relative without arguments. (@viralpraxis)
  • #12710: Fix a false negative for Layout/EmptyLineAfterMagicComment when the file is comments only. (@earlopain)
  • #12758: Fix false positives for Layout/RedundantLineBreak when using && or || after a backslash newline. (@koic)
  • #12763: Fix an infinite loop for Style/MultilineMethodSignature when there is a newline directly after the def keyword. (@earlopain)
  • #12774: Fix an infinite loop for Style/RaiseArgs with EnforcedStyle: compact when passing more than 2 arguments to raise. (@earlopain)
  • #12663: Fix Lint/Syntax getting disabled by rubocop:disable Lint/Syntax. (@earlopain)
  • #12756: Only parse target Ruby from gemspec if array elements are strings. (@davidrunger)

Changes

1.62.0

Note: This is the first RuboCop release that features (experimental) support for using Prism instead of the parser gem. Check out the docs for more details.

See also this article for additional context.

New features

  • #12600: Support Prism as a Ruby parser (experimental). (@koic)
  • #12725: Support TargetRubyVersion 3.4 (experimental). (@koic)

Bug fixes

  • #12746: Fix a false positive for Lint/ToEnumArguments when enumerator is created for another method in no arguments method definition. (@koic)
  • #12726: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method with keyword arguments without parentheses. (@koic)
  • #12738: Fix an error for Style/Encoding when magic encoding with mixed case present. (@koic)
  • #12732: Fix error determining target Ruby when gemspec required_ruby_version is read from another file. (@davidrunger)
  • #12736: Fix invalid autocorrect in Layout/SpaceInsideHashLiteralBraces. (@bquorning)
  • #12667: Don't load excluded configuration. (@jonas054)

1.61.0

New features

  • #12682: Add --editor-mode CLI option. (@koic)
  • #12657: Support AutoCorrect: contextual option for LSP. (@koic)
  • #12273: Make OffenseCountFormatter display autocorrection information. (@koic)
  • #12679: Publish RuboCop::LSP.enable API to enable LSP mode. (@koic)
  • #12699: Support searching for .rubocop.yml and rubocop/config.yml in compliance with dot-config. (@koic)

Bug fixes

  • #12720: Fix a false positive for Style/ArgumentsForwarding when using block arg forwarding to within block with Ruby 3.3.0. (@koic)
  • #12714: Fix an error for Gemspec/RequiredRubyVersion when required_ruby_version is specified with Gem::Requirement.new and is higher than TargetRubyVersion. (@koic)
  • #12690: Fix an error for Style/CaseLikeIf when using == with literal and using ternary operator. (@koic)
  • #12668: Fix an incorrect autocorrect for Lint/EmptyConditionalBody when missing if body with conditional else body. (@koic)
  • #12683: Fix an incorrect autocorrect for Style/MapCompactWithConditionalBlock when using guard clause with next implicitly nil. (@koic)
  • #12693: Fix an incorrect autocorrect for Style/ObjectThen when using yield_self without receiver. (@koic)
  • #12646: Fix --auto-gen-config bug for Layout/SpaceBeforeBlockBraces. (@jonas054)
  • #12717: Fix regexp for inline disable comments in Style/CommentedKeyword. (@jonas054)
  • #12695: Fix bug in Include from inherited file in a parent directory. (@jonas054)
  • #12656: Fix an error for Layout/RedundantLineBreak when using index access call chained on multiline hash literal. (@koic)
  • #12691: Fix an error for Style/MultilineTernaryOperator when nesting multiline ternary operators. (@koic)
  • #12707: Fix false negative for Style/RedundantAssignment when using pattern matching. (@koic)
  • #12674: Fix false negatives for Style/RedundantReturn when using pattern matching. (@koic)
  • #12673: Fix false negatives for Lint/RedundantSafeNavigation when using safe navigation operator for literal receiver. (@koic)
  • #12719: Fix false negatives for Style/ArgumentsForwarding when using forwardable block arguments with Ruby 3.2+. (@koic)
  • #12687: Fix a false positive for Lint/Void when each block with conditional expressions that has multiple statements. (@koic)
  • #12649: Fix false positives for Style/InverseMethods when using relational comparison operator with safe navigation. (@koic)
  • #12711: Handle implicit receivers in Style/InvertibleUnlessCondition. (@sambostock)
  • #12648: Fix numblock regressions in omit_parentheses Style/MethodCallWithArgsParentheses. (@gsamokovarov)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop-rails (2.23.1 → 2.24.1) · Repo · Changelog

Release Notes

2.24.1

Bug fixes

  • #1244: Fix a false positive for Rails/ActionControllerFlashBeforeRender when returning redirect_to. (@earlopain)
  • #1255: Fix an error for Rails/UniqBeforePluck with EnforcedStyle: aggressive when no receiver. (@earlopain)
  • #1247: Fix an error for Rails/UnusedIgnoredColumns when without tables in db/schema.rb. (@koic)
  • #1253: Fix an error for Rails/WhereMissing with leading where without receiver. (@earlopain)
  • #1254: Fix an error for Rails/ExpandedDateRange when passing an argument only to the first method call for weeks. (@earlopain)
  • #1256: Fix an error for Rails/ActiveSupportOnLoad when calling without arguments. (@earlopain)
  • #1230: Fix a false positive for Rails/SaveBang if persisted? is checked on parenthesised expression. (@earlopain)
  • #1200: Make Rails/TimeZone aware of safe navigation. (@earlopain)

Changes

  • #1257: Add Rails 7.1 load hooks and active_record_sqlite3adapter to Rails/ActiveSupportOnLoad. (@earlopain)

2.24.0

New features

  • #1245: Support Prism as a Ruby parser (experimental). (@koic)

Bug fixes

  • #1234: Fix an incorrect autocorrect for Rails/FindBy when using multi-line leading dot method calls. (@ymap)
  • #1241: Fix an error for Rails/WhereExists with EnforcedStyle: where and implicit receivers. (@earlopain)

Changes

  • #1229: Make Rails/EnvironmentVariableAccess aware of initializers. (@markokajzer)
  • #1231: Remove object_id from Rails/DangerousColumnNames targets. (@r7kamura)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop-rspec (2.26.1 → 2.29.2) · Repo · Changelog

Release Notes

2.29.2

  • Fix beginless and endless range bug for RepeatedIncludeExample cop. (@hasghari)
  • Fix a false positive for RSpec/RepeatedSubjectCall when subject is used as argument to function call. (@K-S-A)

2.29.1

  • Fix an error in the default configuration. (@ydah)

2.29.0

  • Fix an autocorrect error for RSpec/ExpectActual. (@bquorning)
  • Add new RSpec/UndescriptiveLiteralsDescription cop. (@ydah)
  • Add new RSpec/EmptyOutput cop. (@bquorning)

2.28.0

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. (@ydah)

2.27.1

  • Fix a false positive for RSpec/RepeatedSubjectCall when subject.method_call. (@ydah)
  • Add configuration option OnlyStaticConstants to RSpec/DescribedClass. (@ydah)

2.27.0

  • Add new RSpec/IsExpectedSpecify cop. (@ydah)
  • Add new RSpec/RepeatedSubjectCall cop. (@drcapulet)
  • Add support for assert_true, assert_false, assert_not_equal, assert_not_nil, *_empty, *_predicate, *_kind_of, *_in_delta, *_match, *_instance_of and *_includes assertions in RSpec/Rails/MinitestAssertions. (@ydah, @G-Rath)
  • Support asserts with messages in Rspec/BeEmpty. (@G-Rath)
  • Fix a false positive for RSpec/ExpectActual when used with rspec-rails routing matchers. (@naveg)
  • Add configuration option ResponseMethods to RSpec/Rails/HaveHttpStatus. (@ydah)
  • Fix a false negative for RSpec/DescribedClass when class with constant. (@ydah)
  • Fix a false positive for RSpec/ExampleWithoutDescription when specify with multi-line block and missing description. (@ydah)
  • Fix an incorrect autocorrect for RSpec/ChangeByZero when compound expectations with line break before .by(0). (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activesupport (indirect, 7.1.3 → 7.1.3.2) · Repo · Changelog

Release Notes

7.1.3.2 (from changelog)

  • No changes.

7.1.3.1 (from changelog)

  • No changes.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ bigdecimal (indirect, 3.1.6 → 3.1.8) · Repo · Changelog

Release Notes

3.1.8

What's Changed

New Contributors

Full Changelog: v3.1.7...v3.1.8

3.1.7

What's Changed

  • Use macos-arm-oss and latest versions for test and benchmark CI by @hsbt in #285
  • Support Ruby 3.4's new error message format by @mame in #286
  • Rename rake spec with rake test in documentation by @rhannequin in #287

New Contributors

Full Changelog: v3.1.6...v3.1.7

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ drb (indirect, 2.2.0 → 2.2.1) · Repo

Release Notes

2.2.1

What's Changed

  • Use a single quote instead of a backtick as an open quote by @mame in #25
  • Drop dependency on ruby2_keywords by @Earlopain in #27
  • Fix warnings during test runs by @Earlopain in #26

New Contributors

Full Changelog: v2.2.0...v2.2.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ i18n (indirect, 1.14.1 → 1.14.5) · Repo · Changelog

Release Notes

1.14.5

What's Changed

  • Explicitly bundle racc gem for Ruby 3.3+ by @amatsuda in #690
  • Optimize I18n::Locale::Fallbacks#[] for recursive locale mappings by @uiur in #692
  • Add I18n.interpolation_keys by @tom-lord in #682
  • Fix syntax in documentation for I18n::Backend::Base.interpolate by @tom-lord in #691
  • Fix that escaped interpolations with reserved keywords raised ReservedInterpolationKey by @Bilka2 in #688

New Contributors

Full Changelog: v1.14.4...v1.14.5

1.14.4

What's Changed

Note: the racc dependency will be coming back in Version 2.

  • undo strict racc dependency on this branch by @radar in #687

Full Changelog: v1.14.3...v1.14.4

1.14.3

What's Changed

  • Pass options to along to exists? super calls by @radar in #671
  • Improve TOKENIZER by 23% by @kbrock in #668
  • Regex part deux - INTERPOLATION_SYNTAX by @kbrock in #669
  • Raise when translated entry contains interpolations for reserved keywords and no substitutions provided by @fatkodima in #678
  • Implement Fallbacks#inspect and Fallbacks#empty? by @fatkodima in #683

Upkeep

New Contributors

Full Changelog: v1.14.1...v1.14.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.7.1 → 2.7.2) · Repo · Changelog

Release Notes

2.7.2

What's Changed

  • Use rb_sym2str instead of SYM2ID by @jhawthorn in #561
  • Fix memory leak when exception is raised during JSON generation by @peterzhu2118 in #574
  • Remove references to "19" methods in JRuby by @headius in #576
  • Make OpenStruct support as optional by @hsbt in #565
  • Autoload JSON::GenericObject to avoid require ostruct warning in Ruby 3.4 by @tompng in #577
  • Warn to install ostruct if json couldn't load it by @hsbt in #578

New Contributors

Full Changelog: v2.7.1...v2.7.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.22.2 → 5.22.3) · Repo · Changelog

Release Notes

5.22.3 (from changelog)

  • 1 minor enhancement:

    • MASSIVE improvement of minitest’s pride plugin output: Frequencies doubled! Sine waves shifted!! Comments improved!!! Colors rotated!!!! (havenwood)

  • 3 bug fixes:

    • Improved wording on Minitest::Test#parallelize_me! to clarify it goes INSIDE your test class/describe.

    • Minor changes to tests to pass when tests ran with extra flags (eg -p).

    • Support Ruby 3.4’s new error message format. (mame)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.3.0.5 → 3.3.1.0) · Repo · Changelog

Release Notes

3.3.1.0 (from changelog)

API modifications:

  • Bump parser branches to 3.0.7, 3.1.5, 3.2.4, 3.3.1 (#1011) (Ilya Bylich)
  • Use require_relative in the Parser codebase (#1003) (Koichi ITO)

Features implemented:

  • ruby{33,34}.y: allow blocks inherit anonymous args. (#1010) (Ilya Bylich)
  • Raise a more specific error when encountering an unknown magic comment encoding (#999) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rack (indirect, 3.0.9 → 3.0.11) · Repo · Changelog

↗️ rubocop-ast (indirect, 1.30.0 → 1.31.3) · Repo · Changelog

Release Notes

1.31.3 (from changelog)

Bug fixes

  • #289: Fix an error during parsing when encountering unknown encodings in the encoding magic comment. (@Earlopain)

1.31.2 (from changelog)

Bug fixes

  • #286: Improve error message for invalid parser_engine value. (@Earlopain)

1.31.1 (from changelog)

Changes

  • #282: Remove Prism from runtime dependency. (@koic)

1.31.0 (from changelog)

New features

  • #277: Support Prism as a Ruby parser (experimental). (@koic)
  • #276: Support Parser::Ruby34 for Ruby 3.4 parser (experimental). (@koic)

Changes

  • #279: (Compatibility) Drop Ruby 2.6 runtime support. (@koic)
  • #272: Make Node#left_curly_brace? aware of lambda brace. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 rubocop-rspec_rails (added, 2.28.3)

🗑️ ruby2_keywords (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
Go to the Depfu Dashboard to see the state of your dependencies and to customize how Depfu works.

@depfu depfu bot added the depfu label May 10, 2024
Copy link
Contributor Author

depfu bot commented May 24, 2024

Closed in favor of #146.

@depfu depfu bot closed this May 24, 2024
@depfu depfu bot deleted the depfu/update/rubocop-1.63.5 branch May 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants