-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: auto_inactive:false to createDeploymentStatus #726
base: develop
Are you sure you want to change the base?
Conversation
fyi @nwtgck ^ |
@nojvek What about clicking the following ✅ and go Netlify? Each commit has ✅. |
That works. Although the deployment that shows at the bottom near the review section goes stale when any new deployment with same environment is made. This would save 2 clicks, and be less confusing as the deploy link would always be there. |
@nwtgck - any blockers on merging this? |
No blocking. I've not tryied |
Kind ping on this @nwtgck ^ I know can clone this repo to unblock myself, but would be nice to land this one line change and keep it in orig repo. |
Another kind ping on this @nwtgck plz. |
Just following up. Anything blocking? |
I apologize for the very long wait. I finally tried this feature on nwtgck/use-actions-netlify#25. But unfortunately, I'm not sure the difference between |
ping |
Github automatically makes any previous environments stale, if there is a new deployment status. With Netlify, the urls still remain valid even if there is a new status.
In our case, we use netlify for PR builds i.e every commit gets a unique netlify link. The issue is Github UI loses that link when anyone else adds a new commit.
By making auto_inactive: false, the links would preserve and Github's UI would be useful.