Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deployment link on pull request if CI is running on pull request #516

Merged
merged 1 commit into from Apr 29, 2021

Conversation

nojvek
Copy link
Contributor

@nojvek nojvek commented Apr 27, 2021

This action has a bug where the deployment link doesn't show on pull request.

Expected: A deployment link is shown in PR timeline:

image

This action has a bug where the deployment link doesn't show on pull request.
@nojvek
Copy link
Contributor Author

nojvek commented Apr 27, 2021

fyi @nwtgck ^

@github-actions github-actions bot temporarily deployed to commit April 29, 2021 01:14 Inactive
@nwtgck
Copy link
Owner

nwtgck commented Apr 29, 2021

@nojvek

Thanks! But, this action already shows a deployment link as follows on a PR.
image
(17 days ago)

actual: nwtgck/piping-ui-web#842

@nwtgck
Copy link
Owner

nwtgck commented Apr 29, 2021

But, anyway I tested this PR on #522

@nojvek
Copy link
Contributor Author

nojvek commented Apr 29, 2021 via email

@nwtgck
Copy link
Owner

nwtgck commented Apr 29, 2021

@nojvek Thank you so much for the detail. I'll reproduce and check the issue. Do you have a reproduced PR? If it is an open PR, I'd like to see it.

@nojvek
Copy link
Contributor Author

nojvek commented Apr 29, 2021

It’s in a private repo. I’ll have to see whether I can make an open repo with a repro.

As additional context it has GitHub setting “enforce linear history” turned on.

@nojvek
Copy link
Contributor Author

nojvek commented Apr 29, 2021

@nwtgck see more context on this https://github.community/t/github-sha-isnt-the-value-expected/17903

I borrowed this functionality from other netlify action that did post deploy links reliably https://github.com/South-Paw/action-netlify-deploy/blob/master/src/main.ts#L13-L21

However that action doesn't output the url that was deployed, but this action does that so trying to make it better.

@nwtgck
Copy link
Owner

nwtgck commented Apr 29, 2021

@nojvek Thank you so much for the detailed explanation!

@nwtgck nwtgck merged commit f730875 into nwtgck:develop Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants