feat: Github deployment description support #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
changed the title
|
Great! I'll make a small modification. |
|
I'm not sure where the description is shown on GitHub UI. But, I'll merge this. test: #514 |
polarathene
reviewed
May 6, 2021
| @@ -184,8 +186,15 @@ export async function run(inputs: Inputs): Promise<void> { | |||
| : context.issue.number !== undefined | |||
| ? 'pull request' | |||
| : 'commit') | |||
|
|
|||
| const description = inputs.githubDeploymentEnvironment() | |||
There was a problem hiding this comment.
Typo. This is why I'm noticing the environment in the deployment description. When using this feature, you can query deployments via CLI like so:
curl -H "Accept: application/vnd.github.v3+json" https://api.github.com/repos/nwtgck/actions-netlify/deployments | less
Then look at the JSON data, something like:
"task": "deploy",
"original_environment": "pull request",
"environment": "pull request",
"description": null,
null would be pull request currently if you enabled the description feature. pull request is the default PR deploy environment if you've not configured a different one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for providing a description text for github deployment.