Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): bump @actions/github from 4.0.0 to 5.1.1 #829

Merged
merged 3 commits into from Dec 3, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2022

Bumps @actions/github from 4.0.0 to 5.1.1.

Changelog

Sourced from @​actions/github's changelog.

5.1.1

  • Export default octokit options #1188

5.1.0

  • Add additionalPlugins parameter to getOctokit method #1181
  • Dependency updates #1180

5.0.3

    • Update to v2.0.1 of @actions/http-client #1087

5.0.2

  • Update to v2.0.0 of @actions/http-client

5.0.1

5.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 2, 2022
@dependabot dependabot bot requested a review from nwtgck October 2, 2022 19:15
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/actions/github-5.1.1 branch from af234a8 to 3dbcdef Compare October 14, 2022 22:10
@github-actions github-actions bot temporarily deployed to commit October 14, 2022 22:10 Inactive
@nwtgck
Copy link
Owner

nwtgck commented Oct 15, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/actions/github-5.1.1 branch from 3dbcdef to 399ad72 Compare October 15, 2022 05:05
@github-actions github-actions bot temporarily deployed to commit October 15, 2022 05:05 Inactive
@github-actions github-actions bot temporarily deployed to commit October 15, 2022 05:09 Inactive
@arminrosu
Copy link

arminrosu commented Nov 18, 2022

@nwtgck while the netlify deploy succeeds, it looks like the build-test workflowis failing because of bad GITHUB_TOKEN?!

RequestError [HttpError]: Resource not accessible by integration
# ...
request: {
    method: 'POST',
    url: 'https://api.github.com/repos/nwtgck/actions-netlify/commits/58d6972a274f6ddb0b6388[49](https://github.com/nwtgck/actions-netlify/actions/runs/3254493379/jobs/5342808157#step:4:50)4ee35d89302c837b/comments',

Odd, secrets.GITHUB_TOKEN should have access by default, unless you restricted the permissions. Looks like all dependabot PRs are affected.

Was this intentional? Hope I'm not bothering.


Edit: Hang on, looks like the workflow is failing only on pull_request triggers, but working on push: https://github.com/nwtgck/actions-netlify/actions/workflows/test.yml

And it's been like that for 3 months. The pull_request workflow runs (and fails) before the push workflow. Both workflows report having status write permissions.

I was expecting the test workflow to be only triggered once, e.g.:

on:
  push:
    branches:
      - develop
      - master
  pull_request:
    branches:
      - develop

Very odd. Why is this happening?

@nwtgck
Copy link
Owner

nwtgck commented Dec 3, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 3, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot bot and others added 2 commits December 4, 2022 00:22
Bumps [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github) from 4.0.0 to 5.1.1.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github)

---
updated-dependencies:
- dependency-name: "@actions/github"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@nwtgck nwtgck force-pushed the dependabot/npm_and_yarn/actions/github-5.1.1 branch from ec904fe to 3594149 Compare December 3, 2022 15:22
@github-actions github-actions bot temporarily deployed to commit December 3, 2022 15:23 Inactive
@github-actions github-actions bot temporarily deployed to commit December 3, 2022 15:31 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

@github-actions github-actions bot temporarily deployed to pull request December 3, 2022 15:31 Inactive
@nwtgck
Copy link
Owner

nwtgck commented Dec 3, 2022

I added pull-requests: write and fixed it.
0a6ec32

@nwtgck nwtgck merged commit af8e900 into develop Dec 3, 2022
@nwtgck nwtgck deleted the dependabot/npm_and_yarn/actions/github-5.1.1 branch December 3, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants