Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Carousel): prevent mouse click when dragging #1781

Merged
merged 2 commits into from May 15, 2024

Conversation

mukundshah
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If <NuxtLink> is used inside the carousel, dragging will cause the link to be clicked. Now onwards, onMouseMove will add 'pointer-events': "none" to the carouselEl and will be removed onMouseUp, thereby preventing click to be propagated.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@mukundshah mukundshah changed the title fix: prevent mouse click when dragging fix(Carousel): prevent mouse click when dragging May 14, 2024
@benjamincanac benjamincanac merged commit 4f0d00f into nuxt:dev May 15, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants