feat(Table): add rowClass to columns list #1632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,6 +29,7 @@ Use the `columns` prop to configure which columns to display. It's an array of o | |||
| - `sortable` - Whether the column is sortable. Defaults to `false`. | |||
| - `direction` - The sort direction to use on first click. Defaults to `asc`. | |||
| - `class` - The class to apply to the column cells. | |||
There was a problem hiding this comment.
Why not use the class field already dedicated to this?
There was a problem hiding this comment.
The class field only seems to be applied to the <th> of the column, if I use block lg:hidden there it will only hide the header and not the data cells <td>.
I would prefer having a way to add a class from the columns list instead of having to modify the rows I pass into the Table component to set classes on data cells.
galexrt
force-pushed
the
table_row_class
branch
from
f7d4952
to
8b5007e
Compare
This allows the columns list to specify a class to be set on the rows columns. Signed-off-by: Alexander Trost <galexrt@googlemail.com>
galexrt
force-pushed
the
table_row_class
branch
from
8b5007e
to
30bc067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This allows the columns list to specify a class to be set on the rows columns.
Implements the idea from my comment here: #527 (comment)
📝 Checklist
I could add more info to the documentation about this feature if wanted.