-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to run e2e tests against existing server #803
base: main
Are you sure you want to change the base?
Conversation
@danielroe friendly ping. Is there anything a can improve in this PR? |
I love this and would like to get this or something like it merged, but just want to make sure we do it in the best way. Will review soon. |
@tobiasdiez Is the only use-case here avoiding restarting/rebuilding the server when running tests? (ie. if we can solve that issue, do you still think this is a needed feature?) |
My use cases are:
Personally, the first use case is actually more important for me. |
Allow to pass the url of an already running server to
setup
and use this as the target instead of building and running a new server. This has two use cases:Usage:
(or of course just using a hard-coded url)