Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @babel/preset-env to 2.13.x #8887

Merged
merged 4 commits into from Feb 24, 2021
Merged

fix: update @babel/preset-env to 2.13.x #8887

merged 4 commits into from Feb 24, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 23, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

#8882 #8883

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@mainrs
Copy link

mainrs commented Feb 23, 2021

Is this the PR that is meant to include the functions that were present in the utils file?

@manniL
Copy link
Member

manniL commented Feb 23, 2021

Is this the PR that is meant to include the functions that were present in the utils file?

Nope, that happened in #8883 :)

@clarkdo
Copy link
Member

clarkdo commented Feb 23, 2021

@pi0 Are you still looking into this? Do you want me to have a look?

@pi0
Copy link
Member Author

pi0 commented Feb 23, 2021

@clarkdo Sure. Feel free selfassigning. Made it as a placeholder to keep track

@clarkdo clarkdo self-assigned this Feb 23, 2021
@clarkdo
Copy link
Member

clarkdo commented Feb 23, 2021

@pi0 unknown polyfill "es6.array.slice" has been fixed in babel/babel#12870 since babel v7.13.5, I pushed a temp fix for another missing polyfill error unknown polyfill "web.dom.iterable" in compat-data and commented in babel orignal pr

@clarkdo clarkdo marked this pull request as ready for review February 23, 2021 22:12
clarkdo
clarkdo previously approved these changes Feb 23, 2021
@clarkdo
Copy link
Member

clarkdo commented Feb 23, 2021

@pi0 Can you give me a review on this ?

if (corejs.version === 2) {
const corejs2BuiltIns = require('@babel/compat-data/corejs2-built-ins')
corejs2BuiltIns['web.dom.iterable'] = {}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in babel-plugin-polyfill-corejs2@0.1.6, sorry!

@pi0
Copy link
Member Author

pi0 commented Feb 24, 2021

Tests seem passing. Thanks so much @nicolo-ribaudo @clarkdo for helping on this 💯

Merging to try on nuxt-edge. (releasing by 2.16 to ensure everything is stable)

This was referenced Mar 15, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants