Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server, vue-app): address encoding issues with query params #8748

Merged
merged 13 commits into from Feb 4, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 2, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Checklist:

  • I have added tests to cover my changes
  • All new and existing tests are passing

@danielroe danielroe changed the title fix(server, vue-app): address further encoding issues fix(server, vue-app): address encoding issues with query params Feb 2, 2021
@danielroe danielroe self-assigned this Feb 2, 2021
@danielroe danielroe marked this pull request as ready for review February 2, 2021 23:49
@pi0
Copy link
Member

pi0 commented Feb 3, 2021

@danielroe Seems normalizeURL is already fixing encoding issues for cases in #7600 since internally decode implementation in ufo us by try/catch (/%c ~> /%25c and /% ~> /%25) which fixes issue when using direct+invalid link. Is there any other condition not handled? (this reverts #5243 and #5243 since this two cases are handled now)

@danielroe
Copy link
Member Author

danielroe commented Feb 3, 2021

@pi0 Internally I did fix that case but it involved changes across more of the code base so opted not to submit in this PR - the devMiddleware in particular would need to be changed.

Would be very happy to push more changes if you would like to go in that direction - but will wait for your go-ahead as I see you are making them now :-)

@danielroe danielroe merged commit 07dd2cc into dev Feb 4, 2021
@danielroe danielroe deleted the query-encoding branch February 4, 2021 18:52
@pi0 pi0 mentioned this pull request Feb 9, 2021
@leochen-g
Copy link

nuxt version is 2.15.8

It seems also have this problem. You can try this dynamic params 司机指南-优步司机、滴滴司机端注册�%B. URI malformed will also appear.

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants