Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issues with route normalization #8462

Merged
merged 5 commits into from Dec 9, 2020
Merged

fix: fix issues with route normalization #8462

merged 5 commits into from Dec 9, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 9, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

History: vuejs/vue-router#3350 > #8325 > #8421 > #8430

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from Atinux, clarkdo, danielroe and a team December 9, 2020 20:39
@pi0 pi0 changed the base branch from dev to 2.x December 9, 2020 20:42
packages/vue-app/template/utils.js Outdated Show resolved Hide resolved
@pi0 pi0 requested a review from clarkdo December 9, 2020 21:08
@codecov-io
Copy link

Codecov Report

Merging #8462 (ba4dbdd) into 2.x (e97051a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #8462   +/-   ##
=======================================
  Coverage   68.23%   68.23%           
=======================================
  Files          91       91           
  Lines        3904     3904           
  Branches     1066     1066           
=======================================
  Hits         2664     2664           
  Misses       1005     1005           
  Partials      235      235           
Flag Coverage Δ
unittests 68.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/config/src/options.js 94.53% <100.00%> (-0.05%) ⬇️
packages/utils/src/route.js 93.16% <100.00%> (ø)
packages/webpack/src/config/client.js 70.27% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97051a...ba4dbdd. Read the comment docs.

@pi0 pi0 marked this pull request as ready for review December 9, 2020 23:19
@pi0 pi0 merged commit 966796f into 2.x Dec 9, 2020
@pi0 pi0 deleted the fix/link-normalization branch December 9, 2020 23:29
@pi0 pi0 mentioned this pull request Dec 16, 2020
7 tasks
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"export 'normalizeURL' was not found in '@nuxt/ufo' [IE]
4 participants