fix(vue-app): fix regression with scrollToTop

[pi0]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

vue-router@3.4.0 landed with vuejs/vue-router#3199 which is breaking scrollToTop: false as we need to call triggerScroll event on first page too otherwise it will be delayed until next navigation which causes jumping to top (or saved position of previous page)

PR also introducing some code refactors

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-commenter]

Codecov Report

Merging #7920 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #7920   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files          91       91           
  Lines        3846     3846           
  Branches     1041     1041           
=======================================
  Hits         2651     2651           
  Misses        971      971           
  Partials      224      224           

Flag	Coverage Δ
#unittests	68.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b487c7d...43b385a. Read the comment docs.

[pi0]

@posva Do you think it is a safe check for detecting initial load?

[posva]

not completely sure, we could also check if from is the START location that is exported in v4.

[pi0]

I tried exposing START ref but checking here, on initial load from and to are same references but not equal to START:

[pi0]

merging to fix ci and test on edge