Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): font-family hex issue #7763

Merged
merged 1 commit into from Jul 26, 2020
Merged

fix(webpack): font-family hex issue #7763

merged 1 commit into from Jul 26, 2020

Conversation

farnabaz
Copy link
Member

Preserve quotes in font values to prevent Hex conversion by clean-css.
Close #6306

Types of changes

  • [X ] Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #7763 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7763   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files          90       90           
  Lines        3821     3821           
  Branches     1034     1034           
=======================================
  Hits         2630     2630           
  Misses        968      968           
  Partials      223      223           
Flag Coverage Δ
#unittests 68.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/webpack/src/utils/postcss.js 84.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f204c...9c2006f. Read the comment docs.

@manniL
Copy link
Member

manniL commented Jul 24, 2020

Oh, very nice! 👍
Maybe it is worth adding a small test for it? 🤔

@pi0 pi0 changed the title fix: font-family Hex issue fix(webpack): font-family hex issue Jul 26, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@pi0 pi0 merged commit 4f27cdd into dev Jul 26, 2020
@pi0 pi0 deleted the postcss-fontvalues branch July 26, 2020 15:49
@pi0
Copy link
Member

pi0 commented Jul 26, 2020

@farnabaz Would be nice if we can also have a test for it indeed. Merged to include in 2.14 (tomorrow)

@pi0 pi0 mentioned this pull request Jul 27, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color names in CSS font-family attribute being convered to HEX code only on generate
5 participants