Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid using _path variable #5582

Merged
merged 4 commits into from Apr 22, 2019
Merged

refactor: avoid using _path variable #5582

merged 4 commits into from Apr 22, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 22, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Using path or _path variable may be problematic when also importing path module. Making potential mistakes or bugs. related issue: istanbuljs/babel-plugin-istanbul#201

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

galvez
galvez previously approved these changes Apr 22, 2019
Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A truly neatpicky change :D

@codecov-io
Copy link

Codecov Report

Merging #5582 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5582   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          81       81           
  Lines        2617     2617           
  Branches      665      665           
=======================================
  Hits         2503     2503           
  Misses         95       95           
  Partials       19       19
Impacted Files Coverage Δ
packages/builder/src/builder.js 100% <100%> (ø) ⬆️
packages/generator/src/generator.js 100% <100%> (ø) ⬆️
packages/utils/src/route.js 100% <100%> (ø) ⬆️
packages/utils/src/resolve.js 96.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cc8de...f2eea10. Read the comment docs.

@pi0 pi0 merged commit 111132d into dev Apr 22, 2019
@pi0 pi0 deleted the refactor/no_patch branch April 22, 2019 18:50
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants