feat(nuxt,schema): add new appId option and improve chunk determinism
#27258
+35
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
changed the title
appId option and improve chunk determinism
This was referenced May 17, 2024
Draft
| * For multi-app projects, the unique name of the Nuxt application. | ||
| */ | ||
| appId: { | ||
| $resolve: (val: string) => val ?? 'nuxt-app', |
There was a problem hiding this comment.
Don't we have a risk of name collision in case appId is not filled in in user land and default value nuxt-app is used multiple times?
There was a problem hiding this comment.
well, I would add Symbol('nuxt-app') so that the name does not conflict
This was referenced May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
This adds a new
appIdoption and passes bothappIdandbuildIdvia runtimeConfig. This means we don't have all chunk hashes changing on every build. (Caused by entry file chunk hash changing with new buildId, and then every other file that imported the entry file changing because that file name changed.)