Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update jsdoc for ignore-prefix to clarify ignored files #27065

Merged
merged 3 commits into from May 7, 2024

Conversation

sossost
Copy link
Contributor

@sossost sossost commented May 5, 2024

馃敆 Linked issue

#27064

馃摎 Description

This commit updates the JSDoc comments to clarify the behavior of the ignorePrefix setting in the configuration. The updated documentation now explicitly states that any file in pages/, layouts/, middleware/, store/, and public/ directories will be ignored during the build process if its filename starts with the prefix specified by ignorePrefix.

Copy link

stackblitz bot commented May 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove stylistic changes from the PR 鈽猴笍

@@ -397,8 +442,10 @@ export default defineUntypedSchema({
ignoreOptions: undefined,

/**
* Any file in `pages/`, `layouts/`, `middleware/` or `store/` will be ignored during
* building if its filename starts with the prefix specified by `ignorePrefix`.
* Any file in `pages/`, `layouts/`, `middleware/`, `store/`, and `public/` directories will be ignored during
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think store can be removed here (was Nuxt 2 specific).
Besides that, it'd be good to check in the code which other parts are affected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manniL oh. I'm sorry. I ran lint:fix to see if stylistic changes are allowed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, if they are from lint:fix that that's fine 馃檲

@danielroe danielroe merged commit 0b8a0ad into nuxt:main May 7, 2024
55 of 56 checks passed
@github-actions github-actions bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants