Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): don't render unknown components with placeholder #18494

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix(nuxt): don't render unknown components with placeholder #18494

merged 2 commits into from
Jan 25, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #18491
resolves #12341

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression of nuxt/framework#9972 was to load <ServerPlaceholder> for all unknown components rather than confirming that there was in fact a client-only component corresponding to them.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Jan 24, 2023
@codesandbox
Copy link

codesandbox bot commented Jan 24, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel vercel bot temporarily deployed to Preview January 24, 2023 21:33 Inactive
@danielroe danielroe requested a review from manniL January 24, 2023 21:45
@vercel vercel bot temporarily deployed to Preview January 25, 2023 08:52 Inactive
@danielroe danielroe merged commit fdb31f4 into main Jan 25, 2023
@danielroe danielroe deleted the fix/registered-components branch January 25, 2023 10:31
This was referenced Jan 25, 2023
Closed
Closed
@lucassimines lucassimines mentioned this pull request Jan 25, 2023
Closed
@danielroe danielroe mentioned this pull request Jan 25, 2023
Merged
@andrew-boyd andrew-boyd mentioned this pull request Jan 25, 2023
Closed
@manniL manniL mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL Awaiting requested review from manniL

Assignees

@danielroe danielroe

Labels
bug ❗ p4-important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hydration node mismatch in 3.1.0 Register vue components in plugin are not working on SSR
1 participant
@danielroe