Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): ensure newly created pages do not return 404 #18447

Merged
merged 9 commits into from
Jan 25, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #15651

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR is to track and resolve a regression requiring the server to be restarted when new routes are created.

This has previously occurred and been resolved in:

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Jan 23, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title test: add failing test fix(vite): ensure newly created pages do not return 404 Jan 23, 2023
@vercel vercel bot temporarily deployed to Preview January 23, 2023 12:06 Inactive
@danielroe danielroe marked this pull request as ready for review January 25, 2023 12:15
@danielroe danielroe merged commit 23e5f98 into main Jan 25, 2023
@danielroe danielroe deleted the fix/route-hmr branch January 25, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New pages 404 unless server is restarted
2 participants