New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): enable devtool for dev mode #6495
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6495 +/- ##
==========================================
+ Coverage 95.67% 95.71% +0.03%
==========================================
Files 79 79
Lines 2708 2708
Branches 699 700 +1
==========================================
+ Hits 2591 2592 +1
+ Misses 101 100 -1
Partials 16 16
Continue to review full report at Codecov.
|
What exactly is the default value currently? Would it be an idea to just set it to I tried this locally but think the errors are still not as helpful as they can be |
I think the default value of webpack may have more consideration and try to keep best practice in both readability and performance. And this config can be easily set via nuxt.config as well. |
The default value is eval in dev mode which includes almost everything in source code |
Looking at https://webpack.js.org/configuration/devtool/, wouldnt it be best for DX to have at least the As you said, if performance is an issue users can always set it back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
TODO: