Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): enable devtool for dev mode #6495

Merged
merged 6 commits into from Oct 19, 2019
Merged

fix(webpack): enable devtool for dev mode #6495

merged 6 commits into from Oct 19, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Oct 1, 2019

Description

TODO:

  • Test dev mode memory usage
  • Update doc for default value

@clarkdo clarkdo requested review from pi0, pimlie and a team October 1, 2019 16:22
@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #6495 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6495      +/-   ##
==========================================
+ Coverage   95.67%   95.71%   +0.03%     
==========================================
  Files          79       79              
  Lines        2708     2708              
  Branches      699      700       +1     
==========================================
+ Hits         2591     2592       +1     
+ Misses        101      100       -1     
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.59% <100%> (ø) ⬆️
#unit 92.35% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 92% <ø> (-0.08%) ⬇️
packages/webpack/src/config/client.js 98.11% <100%> (+0.03%) ⬆️
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010bb20...3ec75bc. Read the comment docs.

@pimlie
Copy link

pimlie commented Oct 8, 2019

What exactly is the default value currently? Would it be an idea to just set it to cheap-module-eval-source-map by default as for the server build?

I tried this locally but think the errors are still not as helpful as they can be

@clarkdo
Copy link
Member Author

clarkdo commented Oct 8, 2019

I think the default value of webpack may have more consideration and try to keep best practice in both readability and performance. And this config can be easily set via nuxt.config as well.

@clarkdo
Copy link
Member Author

clarkdo commented Oct 8, 2019

The default value is eval in dev mode which includes almost everything in source code

aldarund
aldarund previously approved these changes Oct 8, 2019
@pimlie
Copy link

pimlie commented Oct 9, 2019

Looking at https://webpack.js.org/configuration/devtool/, wouldnt it be best for DX to have at least the original source quality by default? eval has the quality generated code which is still not really helpful right?

As you said, if performance is an issue users can always set it back to eval themselves

Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants