This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
chore(eslint): forbid modules importing from core #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkdo
force-pushed
the
chore/module-import
branch
from
64ae550
to
541ccd2
Compare
Deploying with
|
| Latest commit: |
233aaf5
|
| Status: | ⚡️ Build in progress... |
clarkdo
changed the title
|
This is a nice idea! Extending restriction rules, do you think it is also possible to:
|
|
Good point, I’ll look into it |
|
NOTE: this change requires import-js/eslint-plugin-import#2219 to be released. |
clarkdo
force-pushed
the
chore/module-import
branch
from
9a39c84
to
0b116af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Related to #555 (comment), modules in nuxt3 package should not import code from app and core directly, this pr is adding an eslint rule for preventing the unexpected importing.
📝 Checklist