This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(vite)!: upgrade vite to v3 #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
force-pushed
the
chore/vite-3
branch
2 times, most recently
from
ffb68bf
to
bc7c929
Compare
danielroe
force-pushed
the
chore/vite-3
branch
2 times, most recently
from
f29a4f6
to
38826e3
Compare
|
Linking to the |
danielroe
force-pushed
the
chore/vite-3
branch
2 times, most recently
from
7217850
to
cc594b3
Compare
danielroe
force-pushed
the
chore/vite-3
branch
4 times, most recently
from
85f6860
to
a6027e2
Compare
JemiloII
reviewed
Jul 10, 2022
This was referenced Jul 13, 2022
|
Waiting ❤️ |
7 tasks
pi0
approved these changes
Jul 21, 2022
This was referenced Jul 21, 2022
|
Hey guys! I'm excited to get using Vite 3 but I've noticed that this PR actually seems to overwrite user Vite settings (as set in nuxt.config). I think perhaps the configs are provided here in the reverse order... Hopefully it's something just this simple 😅 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR upgrades Vite to v3 beta.
There are a couple of fixes/refactors to note:
We remove the workaround where we move build output files around, instead modifying chunk names (resolves Building to .output is placing public files in 2 separate locations nuxt#12178).
We remove our runtime URL implementation, using new Vite support from feat: experimental.buildAdvancedBaseOptions vitejs/vite#8450.
We'll track the development of this feature quite closely as it moves from experimental into the mainstream, but it will not break in a minor version so the current version constraint is safe.
resolves nuxt/nuxt#13780, resolves nuxt/nuxt#14267, resolves nuxt/nuxt#13953, resolves nuxt/nuxt#13247, resolves nuxt/nuxt#14341, resolves nuxt/nuxt#14327, resolves nuxt/nuxt#14354.
👉 Migration
Vite 3 is a major release with its own breaking changes. Users should read through the migration guide and make any updates necessary. (Other libraries may also have to be updated to work with Vite 3.)
There are no Nuxt-specific changes that users will need to make.